Skip to content

wxGUI/datacatalog: Add Display animation option for space time datasets - #7834

Merged
petrasovaa merged 3 commits into
OSGeo:mainfrom
saket0187:Add-animation-in-context-menu
Aug 25, 2026
Merged

petrasovaa merged 3 commits into
OSGeo:mainfrom
saket0187:Add-animation-in-context-menu

Conversation

@saket0187

Copy link
Copy Markdown
Contributor

This PR adds "Display animation" option for STDS nodes in context menu.

@petrasovaa

@github-actions github-actions Bot added GUI wxGUI related Python Related code is in Python labels Aug 21, 2026
@ninsbl

ninsbl commented Aug 22, 2026

Copy link
Copy Markdown
Member

Nice, adding animations from the context menu works fine when testing it manually.

However, when animating the big test dataset (generated by the script) the gui freezes and finally crashes. After restarting and adding a new animation even the underlying WSL crashes and closes... That is most likely not related to this PR, but something that should be tested more.

Also, we may want to have mechanisms that avoid rengering 100k maps, or at least warn users...

@saket0187

Copy link
Copy Markdown
Contributor Author

Nice, adding animations from the context menu works fine when testing it manually.

However, when animating the big test dataset (generated by the script) the gui freezes and finally crashes. After restarting and adding a new animation even the underlying WSL crashes and closes... That is most likely not related to this PR, but something that should be tested more.

Is it still happening even after the changes from #7811? Also, could you tell me the number of maps in that dataset? I tested it with a dataset containing 1k+ maps, and the animation seems to work fine there.

Also, is the test data you’re using the same one we used for the main STDS PR? If so, please let me know which dataset is causing the issue when running the animation. I’ll try to reproduce it and look into it.

Also, we may want to have mechanisms that avoid rengering 100k maps, or at least warn users...

Regarding avoiding rendering 100k maps, yes, I already have that in mind. I’ll come up with something for this soon.

@ninsbl

ninsbl commented Aug 24, 2026

Copy link
Copy Markdown
Member

Hi @saket0187 : I built directly from your featurebranch, assuming it includes your performance fix.
The dataset that caused my system to crash (the first time) was daily_500 in the p05_big_strds mapset. However, I am not 100% sure the crash is related to the animation change. Because WSL now also crashes at startup and mapset scanning. Will re-build and test more.

One thing tht could be really cool (if possible), would be if a user could click into the rendered image in the animation tool and get a temporal plot (g.gui.tplot)of the animation content...

@saket0187

Copy link
Copy Markdown
Contributor Author

Hi @saket0187 : I built directly from your featurebranch, assuming it includes your performance fix. The dataset that caused my system to crash (the first time) was daily_500 in the p05_big_strds mapset. However, I am not 100% sure the crash is related to the animation change. Because WSL now also crashes at startup and mapset scanning. Will re-build and test more.

One thing tht could be really cool (if possible), would be if a user could click into the rendered image in the animation tool and get a temporal plot (g.gui.tplot)of the animation content...

Interesting, daily_500 seems to work fine on my machine. Maybe something WSL-specific? For now, I have added a warning when a user tries to animate a large STDS through the context menu.

Comment thread gui/wxpython/datacatalog/tree.py Resolved
Comment thread gui/wxpython/lmgr/frame.py Resolved
Comment thread gui/wxpython/lmgr/frame.py Resolved
@saket0187
saket0187 requested a review from petrasovaa August 24, 2026 15:00
@petrasovaa
petrasovaa merged commit 67e876e into OSGeo:main Aug 25, 2026
26 checks passed
@github-actions github-actions Bot added this to the 8.6.0 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI wxGUI related Python Related code is in Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants