Skip to content

r.stats: Use a 64-bit counter for cell counts #7839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pranav-error wants to merge 2 commits into from
Closed

r.stats: Use a 64-bit counter for cell counts #7839

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
526ad6d
r.stats: Use a 64-bit counter for cell counts
Pranav-error Aug 22, 2026
729399f
Merge branch 'main' into fix-rstats-count-overflow
echoix Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions raster/r.stats/stats.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#include <inttypes.h>
#include <stdlib.h>
#include "global.h"

Expand All @@ -23,14 +24,14 @@ struct Node {
struct Node *left;
struct Node *right;
struct Node *list;
long count;
grass_int64 count;
double area;
};

static struct Node **hashtable;
static struct Node *node_list = NULL;
static int node_count = 0;
static long total_count = 0;
static grass_int64 total_count = 0;

int initialize_cell_stats(int n)
{
Expand Down Expand Up @@ -200,7 +201,7 @@ static int node_compare(const void *pp, const void *qq)
static int node_compare_count_asc(const void *pp, const void *qq)
{
struct Node *const *p = pp, *const *q = qq;
long a, b;
grass_int64 a, b;

a = (*p)->count;
b = (*q)->count;
Expand All @@ -213,7 +214,7 @@ static int node_compare_count_asc(const void *pp, const void *qq)
static int node_compare_count_desc(const void *pp, const void *qq)
{
struct Node *const *p = pp, *const *q = qq;
long a, b;
grass_int64 a, b;

a = (*p)->count;
b = (*q)->count;
Expand Down Expand Up @@ -550,7 +551,7 @@ int print_cell_stats(char *fmt, int with_percents, int with_counts,
break;
case CSV:
case PLAIN:
fprintf(stdout, "%s%ld", fs, (long)node->count);
fprintf(stdout, "%s%" PRId64, fs, node->count);
break;
}
}
Expand Down
Loading