Repository navigation
Conversation
echoix
approved these changes
Sep 23, 2026
Member
There was a problem hiding this comment.
Looks fine. Could we have a task item to remove that helper as soon as fixed (and what to fix)? Next step: CI with 26.04 (we should have package lists separated by os version I think), but there’s probably still the issue of numpy 2 and the doctests: probably we could just make them numpy2 only and exclude them from older revisions. I’m not sure the workaround to support both would be worth it.
Also one last thing: what was happening with the blas on Windows? Are we missing something if it isn’t there? (Meaning, if openblas was the alternative of something else, now we wouldn’t have any of both ways of providing a functionality)
Contributor
|
I updated mine, will comment soon |
Contributor
|
The difference of #7724 from this PR is:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a temporary workaround for the current lack of support for
spawnandforkserverstartmethods in multiprocessing.It is necessary for Python 3.14, which uses
forkserveras default startmethod on Linux instead offorkand functions that use Process from multiprocessing (pygrass and temporal) now fail on modern Linux too.The workaround should be removed as soon as proper support for the default startmethods on the different OSes is implemented (see #6104 for status).
The content of this PR should be equivalent to: #7724. However, this one is more comprehensive in that sense that tests now also are executed with Python 3.14 and here all possible occurrences of
spawnserverstartmethod are guarded.I am happy to abandon this PR when #7724 covers the remaining issues...
Given that the Ubuntu 26.04 docker image for main already ships Python 3.14, we should prioritize addressing the 3.14 compatibility issue.