Repository navigation
lib/gis: Fix "Implicit conversion loses precision" warnings - #7947
Conversation
|
The repeated windows failures are odd to me; in this and the other similar PR too it fails. Even after 3 reruns |
Yes, indeed. |
Happens elsewhere too, see #7952 |
|
A probable cause could be mismatch between updated OSGeo4W and cached environment. |
@wenzeslaus, @neteler A cache reset might be what we need here. |
|
Do you mean like this: |
I cleared it all. |
|
I had a doubt that something was changed on the osgeo4w side, but only a backport was there 13 hours ago (when I checked at lunchtime 8-9 hours ago it was there). But now there's another commit pushed 2hours ago. Are there other commits that weren't pushed that affects us? The pytest version is the same as the latest release. I also launched a rerun of a successful run on main of yesterday. I think that it will probably fail if it has something to do with the environment. |
|
The rerun of a previously-passing run failed. https://github.com/OSGeo/grass/actions/runs/36042908364/job/108305431025 I pointed an AI conversation to investigate, and it's getting on a good track: an ABI mismatch with python-gdal with gdal? The change 13 hours ago (backporting) might have been incomplete, or the rebuild on the server is not finished. Cc @jef-n: Do you have an insight on what might have gone wrong? Claude investigation:
Root cause: OSGeo4W
|
|
After further investigation, I'm not too sure about gdal being a problem, maybe just msys2 base packages... to be continued |
|
Still didn’t find the cause. The oldest job I could rerun from main is from a month ago, and it still fails. |
|
Ok I think I have it. (Claude debugging in ci runs on my fork). Essentially, the curl/libcurl uses the new OpenSSL since jef-n/OSGeo4W@d6fc148...b747803#diff-11b789abfab5c961990c23400074fd663571f6c414e8843ffb223139e00de8a1 (2026-09-24), where it jumped from 3.0.22 to 3.5.8.Something looks to have changed in OpenSSL 3.2. There is a dll loading problem, where the OSGeo4W's python copy of So, I think that @jef-n needs to rebuild python for the real fix. I can't really log in easily to osgeo4w's trac, and the github repo doesn't have issues enabled. I'll try again later, if I have time. Otherwise, I encourage someone to file it. There was a commit pushed 3 hours ago (jef-n/OSGeo4W@c15771b) but didn't help to resolve the issue. Here's the final report of the investigation, with the final run that allowed to find the issue by using cdb to dump loader logs. https://github.com/echoix/grass/actions/runs/36258353652/job/108449299525?pr=713 Details
OSGeo4W: Windows loader picks the wrong
|
|
Until something changes on the OSGeo4w packages side, we are kinda stuck with any of our PRs |
Really appreciate your digging! |
|
So the package issue is now fixed, and we can just continue with this. |
GDAL curl requests didn't always tear down cleanly on some platforms and could leave a lock when using GDAL from in sub-threads. This issue has shown up in a few other places qgis/QGIS#66734 OSGeo/grass#7947 qgis/QGIS#66496
echoix
left a comment
There was a problem hiding this comment.
Unlocking you, I don't think there was anything left
Fix all "Implicit conversion loses precision" warnings in lib/gis, like: