Repository navigation
grass.temporal: Raise ValueError on invalid spatial relation - #7949
Merged
echoix merged 1 commit intoOct 2, 2026
Merged
Conversation
In _update_where_statement_by_spatial_extent(), raise a ValueError with
the formatted error message instead of executing a bare raise outside
an except block, which was causing a RuntimeError ("No active exception
to reraise"). Also fix whitespace introduced by backslash continuation.
Fixes OSGeo#7948
Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
echoix
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes error handling in
_update_where_statement_by_spatial_extent()inpython/grass/temporal/abstract_space_time_dataset.py.Previously, when an unsupported
spatial_relationwas passed,self.msgr.error(...)was followed by a bareraisestatement outside of anexceptblock. This caused Python to raise aRuntimeError: No active exception to reraise.The method now properly formats the translatable error message and raises a
ValueError(msg).Motivation and context
Fixes #7948
How has this been tested?
_update_where_statement_by_spatial_extent()with an invalid relation raisesValueErrorwith the expected error message rather thanRuntimeError.overlaps,is_contained,contains) generate expected SQL where clauses.ruff checkandruff format --checkon the modified file.Screenshots (if appropriate)
Types of changes
Checklist