Repository navigation
grass.temporal: Fix error messages when removing map timestamps - #7954
Merged
petrasovaa merged 1 commit intoSep 29, 2026
Merged
petrasovaa merged 1 commit into
petrasovaa merged 1 commit into
Conversation
Contributor
Author
|
The failing |
ninsbl
requested changes
Sep 27, 2026
ninsbl
left a comment
ninsbl
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this. In fact, I may be the one who caused this...
From what I understand, the % formating is the way to go for translatable strings / messages...
ninsbl
approved these changes
Sep 27, 2026
bhuvan-somisetty
force-pushed
the
fix-temporal-remove-timestamp-messages
branch
from
September 29, 2026 07:55
37f1bf6 to
6f979c2
Compare
The vector map message used a %s placeholder with str.format(), so the map name was never inserted and a literal <%s> was shown. The 3D raster map message referred to the map as a raster map, unlike the other messages in Raster3DDataset. Fixes OSGeo#7953. Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
bhuvan-somisetty
force-pushed
the
fix-temporal-remove-timestamp-messages
branch
from
September 29, 2026 08:38
6f979c2 to
c81a9bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two error messages in
remove_timestamp_from_grass()inpython/grass/temporal/space_time_datasets.py:VectorDataset: the message used a%splaceholder withstr.format(),so the map name was never inserted. The placeholder is now
{}.Raster3DDataset: the message said "raster map"; it now says"3D raster map" like the other messages in that class.
Motivation and context
Fixes #7953
Before:
After:
How has this been tested?
pre-commit run --files python/grass/temporal/space_time_datasets.pypasses (ruff check, ruff format, flake8, etc.).
The error path is only reached when the C library fails to remove the
timestamp file, so no test was added for these message-only changes.
Types of changes
functionality to not work as before)
Checklist
pre-defined prefixes
of this project.