Skip to content

lib/dspf: Fix "Implicit conversion loses integer precision" warnings - #8022

Closed
nilason wants to merge 1 commit into
OSGeo:mainfrom
nilason:fix_libdspf_implicit_conversion
Closed

nilason wants to merge 1 commit into
OSGeo:mainfrom
nilason:fix_libdspf_implicit_conversion

Conversation

@nilason

@nilason nilason commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Adresses ” -Wshorten-64-to-32” Clang warnings.

Adresses ” -Wshorten-64-to-32” Clang warnings.
@github-actions github-actions Bot added C Related code is in C libraries labels Oct 5, 2026
@nilason

nilason commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

I wonder if it is not better to remove GRASS library dspf together with r3.mkdspf, which is the only tool depending on it, and r3.showdspf (not compiled since ages). See also #3867.

I'm not familiar with these parts of GRASS at all, but they seem to be unused and definitely unmaintained.
@neteler What do you say?

@neteler

neteler commented Oct 6, 2026

Copy link
Copy Markdown
Member

As the output of r3.mkdspf (manual) is a .dspf display file representing isosurfaces of a 3D raster (voxel) dataset, it can (only?) be used with the r3.showdspf visualization module (G54 (!) manual).

We already wanted to Decide the destiny of r3.mkdspf and r3.showdspf modules in GRASS 7... That tickets was opened 13 years ago and last modified 7 years ago. So, let's get finally rid of it.

@nilason

nilason commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! I wasn’t aware of that ticket. I’ll prepare a retirement PR.

@nilason nilason closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants