Repository navigation
cmake: add missing $<CONFIG> to PATH for multi-config generators - #8026
Merged
Merged
Conversation
Enabling binaries that are needed during build process, to be found, e.g. "output/lib/grass86/bin/Debug/g.mkfontcap", where 'Debug' is the configuration. In addition, generate fontcap from a separate custom target that depends on the completed g.mkfontcap target. Addresses an ad-hoc signature related build failure on Xcode.
Member
|
I’m not super sure about this, an agent had trouble when trying it out. I’m doing more searching before deciding to say there’s something to fix, maybe it’s a fluke. |
echoix
reviewed
Oct 6, 2026
Co-authored-by: Edouard Choinière <27212526+echoix@users.noreply.github.com>
echoix
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing $ to PATH for multi-config generators. Enabling binaries that are needed during build process, to be found, e.g. "output/lib/grass86/bin/Debug/g.mkfontcap", where "Debug" is the configuration.
In addition, generate fontcap from a separate custom target that depends on the completed g.mkfontcap target. Addresses an ad-hoc signature related build failure on Xcode.