Skip to content

grass.script: do not trigger deprecation warning for i.group call in group_to_dict function - #8035

Open
ninsbl wants to merge 6 commits into
OSGeo:mainfrom
ninsbl:group2dict_warning
Open

ninsbl wants to merge 6 commits into
OSGeo:mainfrom
ninsbl:group2dict_warning

Conversation

@ninsbl

@ninsbl ninsbl commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

This PR silences the deprecation warning from the use of the g-flag in i.group. It also adds a pytest for the imagery module.

The tests are written with the help of AI. They depend on #8036

@ninsbl ninsbl added this to the 8.6.0 milestone Oct 8, 2026
@ninsbl
ninsbl requested a review from echoix October 8, 2026 22:01
@ninsbl ninsbl added Python Related code is in Python libraries imagery tests Related to Test Suite labels Oct 8, 2026
@echoix

echoix commented Oct 9, 2026

Copy link
Copy Markdown
Member

I don't think it is silencing the warning if it had been changed to not trigger it at all. There is multiple CI failures, including ones in windows with incomplete gisrc session, that might be happening only because it's the first test of that worker. It's something to not ignore, something in the test or fixture is missing

@ninsbl ninsbl changed the title grass.script: silence deprecation warning for i.group call in group_to_dict function grass.script: do not trigger deprecation warning for i.group call in group_to_dict function Oct 10, 2026
@echoix

echoix commented Oct 10, 2026

Copy link
Copy Markdown
Member

There’s still failures

Comment thread python/grass/script/tests/grass_script_imagery_test.py
Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
@ninsbl
ninsbl requested a review from petrasovaa October 23, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

imagery libraries Python Related code is in Python tests Related to Test Suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants