Repository navigation
style: Fix typos in Python and TeX files and enable codespell for them - #8053
Merged
Merged
Conversation
added 5 commits
October 11, 2026 08:12
Fix typos in comments and docstrings and rename misspelled local variables, attributes and parameters.
Fix misspelled words in comments, docstrings, error messages and test code, and rename misspelled local variables. Abbreviated option names and deliberate fixtures are marked for codespell instead of changed.
Remove the Python and TeX types from the codespell exclusions in pre-commit, add the legitimate identifiers and words that codespell flags to the ignore list, and skip the vendored PLY and ctypesgen code. Typo fixes in the rest of this branch were prepared with an AI coding assistant.
- goodness.tex: Use "In this implementation", matching the
surrounding text.
- grass.temporal: Keep the mapp parameter name of the public
create_time_suffix() so keyword callers keep working, and add it to
the codespell ignore list. The value is a map dataset object, so
map_name was also misleading.
- r.grow test: Rename the variables of test_shrink_null consistently,
which also removes the shrined typo.
- v.report: Name the flag has_table, since it tells whether the layer
has an attribute table linked.
- g.md2man, g.html2man: Use a lowercase word in the codespell:ignore
comments. Codespell only matches lowercase words there, and the
"ignore:" form silenced the whole line.
- Fix adjacent typos left in the edited lines ("an many", "is stayed")
and use names that pair with their counterparts (denominator,
name_template).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| fobj = open(fXML) | ||
| try: | ||
| tree = ET.fromstring(fo.read()) | ||
| tree = ET.fromstring(fobj.read()) |
Member
Author
There was a problem hiding this comment.
Not useful here, the same code as before is there.
github-actions
Bot
added
GUI
petrasovaa
reviewed
Oct 14, 2026
| "point_width", | ||
| ] | ||
| for settKey in settsOrder: | ||
| sett = setts[settKey] |
Contributor
There was a problem hiding this comment.
sett is not used, the whole thing can be removed, also in iscatt/dialogs.py
The sett variable read in the point and selection style layout loops was never used, so drop it together with the merged settings dict it was read from.
| fobj = open(fXML) | ||
| try: | ||
| tree = ET.fromstring(fo.read()) | ||
| tree = ET.fromstring(fobj.read()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the typos codespell reports in Python and TeX files, and enable codespell for those file types in pre-commit.
_()) strings are changed, and the publiccreate_time_suffix(mapp, ...)signature is kept.Motivation and context
Typos in Python and TeX files were not caught by pre-commit.
How has this been tested?
pre-commit run --all-filespasses for codespell, ruff and flake8.Types of changes
Checklist
The typo fixes were prepared with an AI coding assistant.