Repository navigation
CI: Install wxPython and optional dependencies in the update-i18n job - #8054
Merged
Merged
Conversation
Install wxPython (python3-wxgtk4.0) and the optional dependencies of the tools listed in the menus (cairo, fftw, freetype, geos, libsvm, netcdf, opengl, postgres), and configure with the matching flags. AI was used to carry out the trivial work, following the author's implementation choices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’m working on simplifying the collection of strings coming from the xml for the menu strings. While validating, it got noticed that the porting to CI of translation strings update, dropped many strings in the grasswxpy domain. (Near May 2025, in #5752).
I suppose the assumption I was given that collecting strings didn’t really need a full build nor GUI wasn’t entirely true. No it didn’t fail, but it silently created an incomplete file, that was incompletely searched for strings. Optional components built affect what is generated here.
Even though some more complex and complete fixes could be possible, like preventing a successful build if incomplete; deleting incomplete generated xml file; etc, I decided to only keep the simple part, where more strings will come out, that were previously translated.
Note that even though it uses ubuntu-latest, that was 24.04, it will soon be defaulting to 26.04 during a month following October 19, 2026. I didn’t want to bother with the ubuntugis that was not plug and play last time I checked. So, pdal and libLAS will not be built and only get placeholders. It’s an improvement and a compromise.
Since I didn’t want the workflow to break starting next week, I pinned the runner to 24.04 for now.
Details
Description
The
update-i18njob now installs wxPython (python3-wxgtk4.0) and the optional dependencies of the tools listed in the menus (cairo, fftw, freetype, geos, libsvm, netcdf, opengl, postgres), and configures with the matching flags.Motivation and context
Without wxPython,
core/menutree.pyfails onimport wx, andmenustrings.pystays a 3-line stub. Menu and Modeler/Psmap msgids are then missing fromgrasswxpy.pot. Tools that are not built also get "Module not installed" instead of their description.Ubuntu 24.04 does not package PDAL or libLAS, so the point cloud import and export tools still get the placeholder.
How has this been tested?
Ran the job's apt install, configure,
makeandcd locale && make potlocally.menustrings.pyhas 2366 lines andgrasswxpy.potgoes from 3435 to 4541 msgids, including "Raster map calculator".Types of changes
Checklist
pre-defined prefixes
of this project.
AI was used to carry out the trivial work (editing the workflow file, writing the commit and this description), following my implementation choices.