Repository navigation
startup: Skip unreadable database search directories - #8070
Open
NIne-WIngEd wants to merge 4 commits into
Open
NIne-WIngEd wants to merge 4 commits into
NIne-WIngEd wants to merge 4 commits into
Conversation
Refs OSGeo#8027. No source or test changes. AI assistance was used for the issue analysis and draft.
github-actions
Bot
added
Python
NIne-WIngEd
changed the title
Author
|
Hi, just following up on this PR. The checks are passing now. Could you review and merge it if everything looks good? Happy to make any changes needed. Thanks! |
cwhite911
requested changes
Oct 22, 2026
cwhite911
left a comment
cwhite911
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! I've suggested a few minor improvements, but otherwise this looks good to me.
Author
|
Thanks for the review! I replaced the nested try/except blocks with contextlib.suppress. The unreadable-directory test now checks only PermissionError. I also changed deny_listing to patch Path.iterdir directly instead of os.scandir and os.listdir. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRASS now skips unreadable directories instead of crashing at startup. The existing search order and fallback stay the same.
Added tests for permission errors and database discovery.
Fixes #8027