Repository navigation
t.rast.accumulate, t.rast.accdetect: Fix relative time and invalid cycles hang - #8073
Merged
Merged
Conversation
github-actions
Bot
added
temporal
petrasovaa
approved these changes
Oct 18, 2026
petrasovaa
left a comment
petrasovaa
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Claude found a lot of nitpicks, but I think this is good enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #8061 review: relative-time STRDS crashed with a TypeError (cycle, offset and granularity stayed strings), and relative lower/upper/minimum/maximum datasets were rejected because their temporal type was checked before
select(). Zero or negative cycle and granularity, and negative offsets (documented as time skipped between cycles), hung or failed after partial work; they are now rejected up front, and offset 0 still works.Written with Claude Code.