Repository navigation
tests: Pin the cells of a seed for r.random.cells - #8105
Open
Valyrian-Code wants to merge 1 commit into
Open
Valyrian-Code wants to merge 1 commit into
Valyrian-Code wants to merge 1 commit into
Conversation
Adds two tests pinning the cells r.random.cells fills for one seed on a region of 4 by 5 cells, so a change of the random number generator shows as a change of the result. The existing tests check counts and bounds only. Both the distance driven fill and the ncells limited fill are pinned, to catch a change in the order the cells are drawn.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
github-actions
Bot
added
raster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7893, suggested there: pin the cells r.random.cells fills for one seed, so a change of the random number generator shows up.
Uses a region of 4 by 5 cells. Both the distance driven fill and the ncells limited one are pinned, to catch a change in the order the cells are drawn. Same idea as #8077 and #8078.
The existing tests check counts and bounds, which stay as they are.
Suggested squash commit message
tests: Pin the cells of a seed for r.random.cells
Adds two tests pinning the cells r.random.cells fills for one seed on a region of 4 by 5 cells, so a change of the random number generator shows as a change of the result. The existing tests check counts and bounds only.
Both the distance driven fill and the ncells limited fill are pinned, to catch a change in the order the cells are drawn.