Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CurrentMapsetWatch.on_modifiedread GISRC withline.split(":"), which raisesValueErroras soon as a value holds a colon. On Windows that is the usual case,GISDBASE: C:\..., so the watcher thread died there on the first change to GISRC and the Data panel stopped noticing mapset changes. A blank line raised as well.GISRC lines are now split on the first colon, as
read_gisrcinlib/init/grass.pyand the other GISRC readers do, and lines without a colon are skipped.Tested on Windows with wxPython 4.3.2 and watchdog 6.0.0: calling
CurrentMapsetWatch.on_modifiedon a GISRC whoseGISDBASEisC:\grassdataraisesValueError: too many values to unpackon main, and posts the mapset change with this fix. I didn't add a test to the repository: the wxGUI code has no pytest suite, and the pytest workflow doesn't install wxPython.Fixes #8096