Skip to content

fix(passkey): use dedicated qualifier function instead of str #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OffRange merged 1 commit into from
Aug 14, 2026
Merged

fix(passkey): use dedicated qualifier function instead of str #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...ials/src/main/kotlin/de/davis/keygo/feature/credentials/di/annotation/PasskeyQualifier.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package de.davis.keygo.feature.credentials.di.annotation

import org.koin.core.annotation.Named
import org.koin.core.qualifier.Qualifier
import org.koin.core.qualifier.qualifier


@Named
internal annotation class PasskeyQualifier {
@Retention(AnnotationRetention.BINARY)
internal annotation class PasskeyQualifier

companion object {
const val NAMED_QUALIFIER = "PasskeyQualifier"
}
}
internal val PasskeyProviderQualifier: Qualifier = qualifier<PasskeyQualifier>()
5 changes: 2 additions & 3 deletions .../kotlin/de/davis/keygo/feature/credentials/presentation/KeyGoCredentialProviderService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,21 @@ import androidx.credentials.provider.BeginGetCredentialResponse
import androidx.credentials.provider.BeginGetPublicKeyCredentialOption
import androidx.credentials.provider.CredentialProviderService
import androidx.credentials.provider.ProviderClearCredentialStateRequest
import de.davis.keygo.feature.credentials.di.annotation.PasskeyQualifier
import de.davis.keygo.feature.credentials.di.annotation.PasskeyProviderQualifier
import de.davis.keygo.feature.credentials.presentation.create.CredentialCreator
import de.davis.keygo.feature.credentials.presentation.provide.CredentialProvider
import kotlinx.coroutines.CoroutineExceptionHandler
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import org.koin.android.ext.android.inject
import org.koin.core.qualifier.named

@RequiresApi(Build.VERSION_CODES.UPSIDE_DOWN_CAKE)
internal class KeyGoCredentialProviderService : CredentialProviderService() {

private val credentialCreator by inject<CredentialCreator>()
private val passkeyProvider by inject<CredentialProvider<BeginGetPublicKeyCredentialOption>>(
named(PasskeyQualifier.NAMED_QUALIFIER)
PasskeyProviderQualifier
)

override fun onBeginCreateCredentialRequest(
Expand Down
Loading