fix(totp): accept secrets shorter than 128 bits - #74
Merged
Conversation
RFC 4226 asks for at least 128 bits of secret material and totp-rs enforces that, so a shorter secret - GitHub hands those out - was rejected outright. Build through TOTP::new_unchecked instead and run every rule TOTP::new would have applied, minus that floor, then report the weakness through the new SecretStrength on TotpInfo. Scanning an unparseable code from the view screen silently did nothing. It now shows the same parse error dialog the create screen already had, which moved to :feature:totp so both screens can reach it. Closes #68 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
OffRange
force-pushed
the
fix/allow-short-totp-secret
branch
from
August 19, 2026 23:44
388df4a to
a51cba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 4226 asks for at least 128 bits of secret material and totp-rs enforces that, so a shorter secret - GitHub hands those out - was rejected outright. Build through TOTP::new_unchecked instead and run every rule TOTP::new would have applied, minus that floor, then report the weakness through the new SecretStrength on TotpInfo.
Scanning an unparseable code from the view screen silently did nothing. It now shows the same parse error dialog the create screen already had, which moved to :feature:totp so both screens can reach it.
Closes #68