Repository navigation
Process edited sources using immutable revisions - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a source that already had extracted angles returned the source to the bank, but the worker excluded its URL permanently. Old unused angles could also be presented as draftable after the source changed.
This change selects work through revision-aware database views, requires an immutable source revision on the claimed row before model work, and excludes superseded angles from new drafting and inventory. A completed extraction replay reports recovered existing angles rather than claiming they were newly created. Existing approved or published queue items keep their identities and content.
The worker requires the paired
source-revisions-v1database capability and fails closed if it is absent. Deploy only after application migration20261103135010_source_content_revisions.sqland its staging/restart gate pass. Generation and general provider dispatch remain disabled during rollout. Merging this source does not authorize deployment or model calls.Validation: full isolated
npm run cipassed (typecheck, complete regression chain, build, compiled-runtime smoke). Five focused source-revision scenarios intercept all model/HTTP requests and cover edited content, exact replay, return to a completed earlier revision, wrong/missing claim scope, and a lost commit response followed by exact RPC replay. The paired application change supplies real Postgres RLS, claim, approval-preservation and zero-angle tests.Acceptance ledger: https://github.com/AyobamiH/oneclickpostfactory/issues/46
Additional release gate: 87 native readiness/operator tests and 11 real Workerd transport tests pass, including rejection of a database without source-revisions-v1. The initial Workerd success fixture was updated for the new required capability; the runtime guard remains strict.