Repository navigation
Sync repo from v93 to v93 20261030135150 - #527
Merged
Merged
Conversation
Added entry for October 30, 2026, to suppress empty peer-group warning.
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the peer-group warning fix and accompanying test changes.
No open issues 🎉
What changed in this PR
This PR fixes the Web Portal’s false empty peer-group warning by showing it only when a peer group is explicitly selected.
Changes:
- Restricts the warning to peer-group selection and adds regression tests for selection modes and heading reset.
- Adds API-client tests covering membership DELETE success responses and error handling.
- Updates the changelog and repository sync marker.
| File | Description |
|---|---|
imxweb/projects/qer/src/lib/service-items/serviceitem-list/serviceitem-list.component.ts |
Requires a selected peer group before showing the empty-group warning. |
imxweb/projects/qer/src/lib/service-items/serviceitem-list/serviceitem-list.component.spec.ts |
Tests warning behavior across selection modes and heading reset. |
imxweb/projects/qbm/src/lib/api-client/api-client-fetch.spec.ts |
Tests membership DELETE response handling. |
CHANGELOG.md |
Records the peer-group warning and membership DELETE updates. |
.commit |
Advances the repository sync marker. |
Review effort: Balanced
rkonya
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync from azure