Skip to content

fix(player): switch to a virtual border - #185

Merged
theEvilReaper merged 1 commit into
mainfrom
fix/heartBeat
Aug 17, 2026
Merged

fix(player): switch to a virtual border#185
theEvilReaper merged 1 commit into
mainfrom
fix/heartBeat

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

The game uses the world border effect to indicate when the player has low health, but relies on the instance's world border. This causes a small issue because the effect does not account for changes to the instance's border, such as moving it. As a result, the effect becomes less effective. To avoid this, this pull request adds the usage of a virtual world border in some places.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results

231 files  231 suites   1m 40s ⏱️
275 tests 270 ✅  5 💤 0 ❌
828 runs  813 ✅ 15 💤 0 ❌

Results for commit 50c0a11.

@theEvilReaper
theEvilReaper merged commit c01f281 into main Aug 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant