fix: keep PyMuPDF asset probe from hanging or dropping results - #323
Merged
Conversation
Dense vector pages skip table detection and drawing clustering so probe stays under the 300s child timeout, and workers flush the result queue before exit so an empty-queue crash is retried instead of failing the job. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ith 'import' and 'import from'' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_tablesand drawing clustering on image/vector-dense pages so_probe_assets_workerstays under the 300s child timeout (production lipoprotein PDF page 2 has ~114k drawings).put(), and retry once onexitcode=0with an empty queue so a healthy probe is not reported asSUBPROCESS_CRASH.Test plan
uv run pytest tests/unit/test_probe_dense_visual_assets.py tests/unit/test_pymupdf_subprocess_queue.py tests/unit/test_probe_visible_text.pyjob_6265564f67e8andjob_83eb3d464064after mergeMade with Cursor