fix: allow negative TOC offset scan and page-scaled TOC max_tokens - #324
Merged
Conversation
…TOC extraction limits - Modified the scanning start logic in phase1 to ensure it begins after the TOC, allowing for negative offsets when necessary. - Updated the TOC extraction tool to use a new maximum token limit for anchor confirmation, improving efficiency. - Refactored the token calculation in the VLM TOC extractor to be page count dependent, enhancing flexibility. - Adjusted related tests to reflect changes in scanning behavior and ensure accurate results.
…dget Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toc_end + 1again (printed floor commented for easy restore), so journal-reprint PDFs can calibrate with negative offsets.max_tokensispages × 3000; anchor confirm uses a small fixed512budget.Test plan
make check(lint + typecheck)pytest tests/contract/test_calibration_phase1_contract.pyMade with Cursor