fix: upload local MinerU shards when HeadObject returns 403 - #327
Merged
Conversation
Temp shard keys are not in S3 yet. A forbidden HeadObject must not abort URL mode; upload the local shard and continue with a presigned URL. Co-authored-by: Cursor <cursoragent@cursor.com>
HeadObject 403 happened because split shards were never uploaded. Put them in S3 and confirm they exist after split, then start MinerU, instead of treating 403 as a later upload fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmp/mineru-shards/...keys are not in S3 yet. StagingHeadObjectreturned 403 (not 404), which aborted URL mode and forced a slow direct upload to MinerU.uploads/objects is unchanged.Test plan
uv run pytest apps/worker/tests/unit/test_mineru_pdf_service.pyExercise_Prescription_in_Cardiac_Rehabilitation.pdfon staging and confirm Logfire showsurl_mode_source_unverifiedthenurl_mode_source_uploaded/Using S3 URL mode, not an immediate direct-upload fallback fromverify_source_objectMade with Cursor