Repository navigation
prefetch: Assign prefetch requests to the correct IO class - #983
Merged
Merged
Conversation
rafalste
force-pushed
the
fix_prefetch_part
branch
from
October 8, 2026 14:20
5c2099c to
59e7bcd
Compare
robertbaldyga
requested changes
Oct 8, 2026
rafalste
force-pushed
the
fix_prefetch_part
branch
from
October 8, 2026 15:31
59e7bcd to
3edf31e
Compare
All user requests pass through the ocf_core_volume_submit_io() function which assign its 'part_id' from an internal 'io.io_class' field set when creating the request. When prefetch request is created in ocf_prefetch_range() function, only its 'io.io_class' field is set and since this request does not pass through ocf_core_volume_submit_io() the 'part_id' field is left with unchanged default which points to class 0. Because OCF uses 'part_id' to properly route the request, prefetch requests are inserted into partition 0 instead of the proper 33 which is reserved for prefetcher. Signed-off-by: Rafal Stefanowski <r.stefanowski@pm.me>
rafalste
force-pushed
the
fix_prefetch_part
branch
from
October 8, 2026 15:33
3edf31e to
966d950
Compare
robertbaldyga
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All user requests pass through the ocf_core_volume_submit_io() function which assign its 'part_id' from an internal 'io.io_class' field set when creating the request.
When prefetch request is created in ocf_prefetch_range() function, only its 'io.io_class' field is set and since this request does not pass through ocf_core_volume_submit_io() the 'part_id' field is left with unchanged default which points to class 0.
Because OCF uses 'part_id' to properly route the request, prefetch requests are inserted into partition 0 instead of the proper 33 which is reserved for prefetcher.