Skip to content

Improve configure repoducibility #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbaldyga merged 2 commits into from
Sep 24, 2026
Merged

Improve configure repoducibility #1821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
463fa34
configure: Ensure configure reproducibility
robertbaldyga Sep 24, 2026
11c9a1f
configure: Fix config file ordering grep patern
robertbaldyga Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
WITH_NETLINK=${WITH_NETLINK:-0}
EOF

CONFIG_FILES=`ls $SCRIPTPATH/configure.d/*.conf | sort`
CONFIG_FILES=`ls $SCRIPTPATH/configure.d/*.conf | LC_ALL=C sort`

Check failure on line 160 in configure

View workflow job for this annotation

GitHub Actions / checkpatch review 

WARNING: It's generally not useful to have the filename in the file
FILES_COUNT=`echo $CONFIG_FILES | wc -w`

CONFIG_FILE=$SCRIPTPATH/"config.out"
Expand Down Expand Up @@ -197,14 +197,15 @@
exit 1
fi

LC_ALL=C sort -o ${CONFIG_FILE} ${CONFIG_FILE}
echo "$KERNEL_DIR_TAG $(realpath "$KERNEL_DIR")" >> ${CONFIG_FILE}
}

generate_header() {
rm -f $SCRIPTPATH/modules/generated_defines.h
# Configs starting with '1_' have to be put as first in header
FIRST=$(echo $CONFIG_FILES | tr ' ' '\n' | grep '1_')
SECOND=$(echo $CONFIG_FILES | tr ' ' '\n' | grep '2_')
FIRST=$(echo $CONFIG_FILES | tr ' ' '\n' | grep '/1_[^/]*$')
SECOND=$(echo $CONFIG_FILES | tr ' ' '\n' | grep '/2_[^/]*$')

echo "#ifndef __GENERATED_DEFINES_H__" >> $SCRIPTPATH/modules/generated_defines.h
echo "#define __GENERATED_DEFINES_H__" >> $SCRIPTPATH/modules/generated_defines.h
Expand Down
Loading