Repository navigation
DEB package fixes and tests - #1822
Merged
Merged
Conversation
debhelper keeps the services' enablement symlinks until the package is
purged. open-cas.service is RequiredBy local-fs.target, so after a plain
'apt remove' local-fs.target requires a unit that no longer exists and
fails to start ('Unit open-cas.service not found'). Drop the symlinks
and their state on remove - a later install enables the services again
the same way a fresh one does. This matches the RPM, which disables the
services when the package is erased.
Also remove the Python bytecode cache casctl leaves in /usr/lib/opencas,
which kept dpkg from removing the directory - again as the RPM does.
Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
The modules package ships only sources that DKMS builds on the target, yet it was built as architecture specific, depended on debhelper at run time and named the build host's running kernel in its description, as if it carried modules prebuilt for it. Mark it 'Architecture: all', drop the leftover debhelper dependency and describe it as the DKMS package. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Test build (binary, debug and from the source package), installation and removal (with and without purge), reinstall, upgrade/downgrade, the exact version dependency between the tools and the modules, and the DKMS rebuild for a newly installed kernel. DEB packages always ship the modules as DKMS sources, so building a set takes seconds and each test builds what it needs. The newer version is produced by bumping the version file of the sources on the DUT. These tests require Debian-based OS on DUT. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.