feat(download): show the real running desktop app window (v0.6.2 launch fix)#219
Merged
Conversation
…ch fix) The desktop app now launches: desktop-v0.6.2 fixes the startup panic that issue #26 tracked. Replace the cockpit connect-screen capture with a real capture of the actual launched app from the published v0.6.2 macOS arm64 DMG (gh release download, sha256-verified, mounted + installed + `open`ed — the real packaged Tauri window, not a vite/Playwright render), cropped only to trim the OS title bar so the WindowFrame chrome reads cleanly. Copy updates in DesktopPreview: - "What you're installing" intro now states the app launches and v0.6.2 fixed the panic; the window shown is the real app running. - Cockpit caption calls it the real launched-app window (published v0.6.2 DMG). - Windows finish-step caption drops the stale "does not launch yet (issue #26), so no app window is shown" caveat and credits the v0.6.2 fix. Provenance + tests: - MANIFEST.json: cockpit entry re-sourced to desktop-v0.6.2 with the DMG sha256, full screencapture method, new content hash and 2240x1464 dims; finish note updated to reflect the fix. - desktopPreview.test.js: new test asserting the cockpit asset's sha256, dims, v0.6.2 provenance and honesty phrases; the Windows-flow honesty test now asserts the stale caveat is gone and the v0.6.2 fix is credited; cockpit dimension assertion updated to 1120x732. No engine was connected, so only the honest first-run connect screen is shown; no authenticated/workflow states are fabricated. Experimental/unsigned framing preserved. Unit (publicTruth + desktopPreview), next build, and Cypress green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NyCHrzA1psrKMFfroYbzaM
✅ Deploy Preview for cosmic-klepon-3c693c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
abrichr
added a commit
that referenced
this pull request
Jul 20, 2026
Add a Cypress regression assertion that visits /download at 375px and 390px and asserts documentElement.scrollWidth stays within the viewport. Investigation finding: the /download page does NOT currently scroll horizontally at any width from 320-414px in the fully-loaded ready state (chart + stats + install-flow + desktop preview all render and fit). Confirmed by measuring documentElement.scrollWidth and by a full-page mobile screenshot. Recent download-page work (#215/#216/#219/#223/#229) appears to have already resolved any earlier overflow. Because globals.css sets `overflow-x: hidden` on html/body, a naive scrollWidth check would be clamped by Chrome and trivially pass, masking future regressions — and that mask does not reliably stop horizontal panning on iOS Safari, which is the surface this guards. The assertion therefore neutralizes the mask first so it measures the true content width. Verified meaningful: injecting a 900px element with the mask neutralized makes the assertion fail as expected. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The now-fixed OpenAdapt Desktop launches (prerelease desktop-v0.6.2 fixes the startup panic tracked by openadapt-desktop issue #26). The
/downloadDesktopPreview previously showed installer + tray shots and a cockpit render, with copy hedging that the app "does not launch yet." This PR wires in a real capture of the actual launched app and updates the copy to reflect reality.Capture provenance (real, verified)
gh release download desktop-v0.6.2→OpenAdapt-Desktop-Experimental-v0.6.2-macos-arm64-adhoc.dmg, sha256 verified against the releaseSHA256SUMS(d2f343c7…).ditto-installed the.app, launched withopen— the real packaged Tauri window, nottauri dev/vite build/ Playwright.CGWindowListCopyWindowInfo, captured at native retina 2x withscreencapture -l<windowID>, cropped only to trim the OS title bar so theWindowFramechrome reads cleanly (same treatment the tray still already uses)..private/desktop_capture_2026_07_19/macos/.Copy / honesty changes
Provenance test extension
tests/desktopPreview.test.js:96c0c1bc…), dims (2240×1464), v0.6.2 provenance (release tag, launched-app capture method), and honesty phrases.1120×732(title bar trimmed) — zero layout shift.Gates (all green locally)
node --test tests/*.test.js→ 73/73 pass (incl. publicTruth + desktopPreview).next build→ success (prebuild reruns tests).🤖 Generated with Claude Code
https://claude.ai/code/session_01NyCHrzA1psrKMFfroYbzaM