Repository navigation
refactor: Refactor mount calculations, enhance documentation, and add tests - #314
Open
andre-stefanov wants to merge 4 commits into
Open
andre-stefanov wants to merge 4 commits into
andre-stefanov wants to merge 4 commits into
Conversation
- Updated Mount::calculateRAandDECSteppers to utilize a new core::calculateStepperPositions function for improved clarity and maintainability. - Introduced core::SlewGeometry and core::SlewResult structures to encapsulate parameters and results related to slewing calculations. - Replaced direct calculations of RA and DEC stepper positions with a switch-case structure based on the selected solution from the new SlewResult. - Enhanced coordinate formatting functions in CoordinateFormatter to accept DayTime instead of RightAscension, ensuring better type safety and clarity. - Added unit tests for coordinate formatting and coordinate math to validate the new implementations and ensure correctness. - Updated EEPROM layout to reflect changes in data structure and added tests to verify the integrity of the EEPROM layout.
…sidereal time calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.