Fix Playwright sign-in: fill the input inside the password v-text-field - #10
Merged
Merged
Conversation
Login.vue puts data-test=new-password and data-test=confirm-password on v-text-field, which Vuetify renders as a wrapper div around the real input. Playwright refuses to fill a div, so sign-in failed before any plugin was installed and every plugin using the reusable workflow failed its Playwright job. Target the input inside each wrapper instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sign-in in
playwright-plugin/tests/auth.setup.tsfails on every plugin that usesplugin-playwright-reusable.yml, so the plugin never gets installed:COSMOS's
Login.vueputsdata-test="new-password"anddata-test="confirm-password"on a<v-text-field>. Vuetify places that attribute on the wrapper<div>, not on the inner<input>, and Playwright can't fill a div. The fix targets[data-test=...] inputfor the twofill()calls. The visibility checks and the button clicks stay as they are.v-btnrenders a real<button>, so the clicks were never affected.This isn't a COSMOS regression: that part of
Login.vueis identical in v7.3.0 and v7.4.0. The bug slipped through because this is the first plugin run that actually got as far as the harness.Failing run: https://github.com/OpenC3/openc3-cosmos-kayhan/actions/runs/35888888718
Test plan
npm run typecheckandnpm run listpass inplaywright-plugin/🤖 Generated with Claude Code