Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3941 +/- ##
==========================================
+ Coverage 80.08% 80.15% +0.07%
==========================================
Files 901 902 +1
Lines 68356 68448 +92
Branches 2645 2662 +17
==========================================
+ Hits 54743 54865 +122
+ Misses 12946 12920 -26
+ Partials 667 663 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…of building complex table
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
calmonroe
marked this pull request as ready for review
September 28, 2026 23:17
AI adversarial reviewWarning The review did not finish, so there is no result to publish. See the workflow run log. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
Adds fuzzy search capability to Packet Viewer combobox and search bar




The fuzzy search is tolerant of typos, spaces, and partial matches
Dynamically sorts results in order of closest to furthest match
Why it changed
Closes #1992
Testing strategy
Tested with new playwright tests and by trying out the search function in the UI by hand
Review notes
We previously discussed using a pre-existing fuzzy search package, but after consideration I think tuning our own fuzzy search to our particular needs makes more sense. Evaluated fuse.js, uFuzzy, fast-fuzzy, fuzzysort and match-sorter against real INST names: all but uFuzzy failed on recall, and uFuzzy anchors the first and last character of every term, so one typo in a short mnemonic finds nothing (
heal star→ no match); theintraRulesoverride that fixes it returns more junk than the matcher in this PR does. Additionally, building the uFuzzy version in full came out to more code, not less (169 lines vs 153, plus 5KB and a dependency), since the integration work is identical either way and only the search.js file changes.However, I did decide to use
approx-string-matchwhich searches for the closest substring matches for a pattern within a body of text. This helped avoid confusing code that we would have to maintain, which built a table and kept track of matches itself