Repository navigation
Release 0.2.1: fix the static-binary check that stopped 0.2.0's release - #107
Merged
Merged
Conversation
The release refused the x86_64 musl binaries as not statically linked: file describes them as "static-pie linked", while the aarch64 ones read "statically linked", and the check matched the words. Both are static. The workflow now checks the property itself -- no program interpreter and no shared-library dependency in the ELF headers -- and prints file's description only for the log. build-packages.sh, which has only file to hand on a developer machine, accepts both wordings.
0.2.0's images, provenance and chart were published, but the release refused the x86_64 static binaries on the wording of file's output, so no GitHub Release, archives, packages or checksums followed. A published version is never rebuilt, so the fix ships as 0.2.1, the first complete publication of 0.2 -- the same software, with the release check fixed. The workspace, the console, both lockfiles, the chart and every current-version example move to 0.2.1. Kept at 0.2.0: that attestation starts there, and the container-images page's example of a fix superseding a published tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.0 release run published the server and console images, their provenance and SBOMs, and the Helm chart
0.2.0. Its release decision was READY. But Linux packages (amd64) failed:The binary was static.
filedescribes an x86_64 musl build asstatic-pie linkedand an aarch64 one asstatically linked, and the check matched the wording. Because that job failed, the GitHub Release was skipped: no archives, no .deb/.rpm, no checksums and no release notes were published for 0.2.0.A published tag is never rebuilt, and re-running the job would reuse the workflow as it was at the tag. So this ships the fix as 0.2.1.
Changes
release.ymlnow checks the property itself: noINTERPprogram header and noNEEDEDentry (readelf).file's text is only printed.build-packages.sh, which only hasfileon a developer machine, accepts both wordings.release-version.sh v0.2.1passes. Kept at 0.2.0 on purpose: attestation starts at 0.2.0, and the container-images page's example of a fix superseding a published tag.0.2.1section: it is the same software as 0.2.0, the 0.2.0 upgrade notes apply, and a 0.2.0 image can be replaced in place.Evidence (all on the fork)
release.yml: https://github.com/danielmarv/record-store/actions/runs/36183532788static-pieand aarch64statically linkedbinaries both accepted.check-configand serves/ready.093347e(this PR's head): READY SO FAR, 25/25 runnable gates passing, ART-PACKAGE deferred to the tag: https://github.com/danielmarv/record-store/actions/runs/36184230804After merge
Create and push a signed tag on the merge commit:
git tag -s v0.2.1 -m "Record Store v0.2.1". Then watchrelease.yml.🤖 Generated with Claude Code