Skip to content

feat: safe compare ids - #5013

Open
doc-han wants to merge 1 commit into
mainfrom
5010-cannot-read-properties-of-undefined-reading-localecompare
Open

feat: safe compare ids#5013
doc-han wants to merge 1 commit into
mainfrom
5010-cannot-read-properties-of-undefined-reading-localecompare

Conversation

@doc-han

@doc-han doc-han commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

This PR [adds/changes/fixes]... (A description of your work goes here.)

Closes #__

Validation steps

  1. (How can a reviewer validate your work?)

Additional notes for the reviewer

  1. (Is there anything else the reviewer should know or look out for?)

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@doc-han doc-han linked an issue Jul 24, 2026 that may be closed by this pull request
2 tasks
@github-project-automation github-project-automation Bot moved this to New Issues in Core Jul 24, 2026
@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — change is a client-side null-safe sort comparator in useUnsavedChanges.ts:71,83; no queries or web-layer entrypoints touched.
  • S1 (authorization): N/A — no new handlers, controllers, or LiveView events introduced.
  • S2 (audit trail): N/A — no writes to config resources; the diff only affects an in-memory sort for change detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'localeCompare')

1 participant