Repository navigation
fix(imap): align greeting CAPABILITY list with explicit CAPABILITY command - #309
Open
dineth-nimnaka wants to merge 4 commits into
Open
dineth-nimnaka wants to merge 4 commits into
dineth-nimnaka wants to merge 4 commits into
Conversation
|
Collaborator
|
Hi @dineth-nimnaka we have made some changes to our CLA. We need contributors to sign it again. Please let me know if there is any issue. |
Contributor
Author
|
Signed the updated CLA! @maneesha-xyz |
…CAPABILITY command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Aligns the capabilities advertised in the server greeting with the explicit
CAPABILITYcommand response by reusingauth.BuildCapabilitiesas the single source of truth.🔍 Changes Made
buildCapabilitiesasBuildCapabilitiesininternal/server/auth/auth.goso it can be shared across packages.greetingCapabilitiesfunction ininternal/server/server.go.auth.BuildCapabilities, ensuringNAMESPACE,UNSELECT, and all future capabilities stay in sync across greeting and explicit command responses.✅ Checklist (Email System)
LOGIN,CAPABILITY,LIST,SELECT,FETCH,LOGOUT).🧪 Testing Instructions
To test the server, use the instructions in the README in the
testdirectory.* OK [CAPABILITY ...]greeting.CAPABILITYcommand and compare the capability list; verify they are aligned (includingNAMESPACEandUNSELECT).📷 Screenshots / Logs (if applicable)
N/A
Refactored greeting to use
auth.BuildCapabilitiesdirectly to eliminate code duplication and avoid capability drift in the future.