Sync with Haivision SRT 1.5.7 and improve SRTLA reliability

.github/blocked-workflows/ubuntu-c++11-crypto.yml

@@ -0,0 +1,37 @@
+name: Linux
+
+on:
+  push:
+    branches: [ "master", "dev" ]
+  pull_request:
+    branches: [ "master", "dev" ]
+    types: [opened, synchronize, reopened]
+jobs:
+  build:
+    strategy:
+      matrix:
+        crypto: [OFF, openssl, openssl-evp, gnutls, mbedtls, botan]
+
+    name: Build Crypto=${{ matrix.crypto }} C++11
+    runs-on: [ubuntu-latest, ubuntu-slim, ubuntu-24.04-arm]
+    steps:
+    - uses: actions/checkout@v3
+    - name: Configure packages and system
+      run: |
+        sudo apt install -y tcl cmake libssl-dev libgnutls28-dev libmbedtls-dev libbotan-2-dev gdb
+        echo "core.%e" | sudo tee /proc/sys/kernel/core_pattern
+    - name: Configure
+      run: |
+        mkdir _build && cd _build
+        if [[ ${{ matrix.crypto }} != OFF ]]; then CRYPTO_OPTIONS=-DUSE_ENCLIB=${{ matrix.crypto }}; else CRYPTO_OPTIONS=-DENABLE_ENCRYPTION=OFF; fi
+        cmake ../ -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DUSE_CXX_STD=11 -DENABLE_STDCXX_SYNC=ON $CRYPTO_OPTIONS -DENABLE_UNITTESTS=ON -DENABLE_BONDING=ON -DENABLE_HEAVY_LOGGING=ON  -DENABLE_TESTING=ON -DENABLE_EXAMPLES=ON -DENABLE_CODE_COVERAGE=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+    - name: Build
+      run: cd _build && make -j -k
+    - name: test
+      run: |
+        ulimit -c unlimited
+        cd _build && ctest --extra-verbose
+        SUCCESS=$?
+        if [ -f core.test-srt ]; then gdb -batch ./test-srt -c core -ex bt -ex "info thread" -ex quit; else echo "NO CORE - NO CRY!"; fi;
+        test $SUCCESS == 0;
+

.github/blocked-workflows/ubuntu-matrix.yml

@@ -0,0 +1,67 @@
+name: Linux
+
+on:
+  push:
+    branches: [ "master", "dev" ]
+  pull_request:
+    branches: [ "master", "dev" ]
+    types: [opened, synchronize, reopened]
+jobs:
+  build_options:
+    strategy:
+      matrix:
+        cxxstdsync: [OFF, ON]
+        logging:  [OFF, ON]
+        bonding: [OFF, ON]
+        cxxstd: ["03", "11"]
+        exclude:
+          - cxxstd: "11"
+            logging: ON
+            bonding: ON
+          - cxxstd: "03"
+            cxxstdsync: ON
+            bonding: OFF
+    name: Build C++${{ matrix.cxxstd }} C++sync=${{ matrix.cxxstdsync }} Bonding=${{ matrix.bonding }} Logging=${{ matrix.logging }}
+    runs-on: [ubuntu-latest, ubuntu-slim, ubuntu-24.04-arm]
+    steps:
+    - uses: actions/checkout@v3
+    - name: Configure packages and system
+      run: |
+        sudo apt install -y tcl cmake libssl-dev libmbedtls-dev libbotan-2-dev gdb
+        echo "core.%e" | sudo tee /proc/sys/kernel/core_pattern
+    - name: Configure
+      run: |
+        mkdir _build && cd _build
+        # NOTE > Crypto options are default - enabled, openssl
+        cmake ../ -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DUSE_CXX_STD=${{ matrix.cxxstd }} -DENABLE_STDCXX_SYNC=${{ matrix.cxxstdsync }} -DENABLE_UNITTESTS=ON -DENABLE_BONDING=${{ matrix.bonding }} -DENABLE_LOGGING=${{ matrix.logging }} -DENABLE_HEAVY_LOGGING=${{ matrix.logging }} -DENABLE_TESTING=ON -DENABLE_EXAMPLES=ON -DENABLE_CODE_COVERAGE=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
+    - name: Build
+      run: cd _build && make -j -k
+    - name: test
+      run: |
+        ulimit -c unlimited
+        cd _build && ctest --extra-verbose
+        SUCCESS=$?
+        if [ -f core.test-srt ]; then gdb -batch ./test-srt -c core -ex bt -ex "info thread" -ex quit; else echo "NO CORE - NO CRY!"; fi;
+        test $SUCCESS == 0;
+
+    - name: codecov
+      run: |
+        source ./scripts/collect-gcov.sh
+        bash <(curl -s https://codecov.io/bash)
+
+  build_mingw:                                                                                                         
+    name: Build Mingw32
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Dependencies
+      run: |
+        sudo apt install -y g++-mingw-w64-x86-64-posix gcc-mingw-w64-x86-64-posix
+    - name: Configure
+      run: |
+        mkdir _build && cd _build
+        export CC=x86_64-w64-mingw32-gcc-posix CXX=x86_64-w64-mingw32-g++-posix 
+        # NOTE > Temporarily blocked encryption due to problems with enclib
+        cmake .. -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DENABLE_ENCRYPTION=OFF -DENABLE_UNITTESTS=OFF -DUSE_OPENSSL_PC=OFF -DCMAKE_SYSTEM_NAME=Windows
+    - name: Build
+      run: cd _build && make -j -k

.github/workflows/abi.yml

@@ -2,60 +2,152 @@ name: ABI checks
 
 on:
   push:
-    branches: [ master ]
+    branches: [ "master", "dev" ]
   pull_request:
-    branches: [ master ]
+    branches: [ "master", "dev" ]
 
 env:
   SRT_BASE: v1.5.0
 
 jobs:
-  build:
-    name: ABI checks
-    runs-on: ubuntu-20.04
+  build_pr:
+    name: Build current version
+    runs-on: ubuntu-latest
 
+    outputs:
+       base_version: ${{ steps.build.outputs.SRT_BASE }}
+       tag_version: ${{ steps.build.outputs.SRT_TAG_VERSION }}
     steps:
     - uses: actions/checkout@v3
       with:
-        path: pull_request
-    - name: configure
+        path: gitview_pr
+    - id: configure
+      name: Configure (cmake)
       run: |
-        cd pull_request
+        cd gitview_pr
         mkdir _build && cd _build
-        cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_UNITTESTS=ON ../
-    - name: build
+        cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_BONDING=1 -DENABLE_PKTINFO=1 -DENABLE_MAXREXMITBW=1 ../
+    - id: build
+      name: Build and dump
       run: |
-        sudo apt install -y abi-dumper
-        cd pull_request/_build && cmake --build ./
+        sudo apt install -y abi-dumper abi-compliance-checker tcl
+        cd gitview_pr
+        cd _build && cmake --build ./
         make install DESTDIR=./installdir
-        SRT_TAG_VERSION=$(cat version.h |grep SRT_VERSION_MINOR |head -n1 |awk {'print $3'})
-        abi-dumper libsrt.so -o libsrt-pr.dump -public-headers installdir/usr/local/include/srt/ -lver 0
-        SRT_BASE="v1.$SRT_TAG_VERSION.0"
-        echo "SRT_BASE=$SRT_BASE" >> "$GITHUB_ENV"
+        SRT_TAG_VERSION=v$(../scripts/get-build-version.tcl full)
+        echo "SRT_TAG_VERSION=$SRT_TAG_VERSION" >> "$GITHUB_OUTPUT"
+        SRT_TAG=${SRT_TAG_VERSION}dev-$(git rev-parse --short HEAD)
+        echo "TAGGING PR BUILD: $SRT_TAG"
+        abi-dumper libsrt.so -o libsrt-pr.dump -public-headers installdir/usr/local/include/srt/ -lver $SRT_TAG
+        ls -ld libsrt-pr.dump
+        sha256sum libsrt-pr.dump
+        SRT_BASE=v$(../scripts/get-build-version.tcl base)
+        if [[ $SRT_TAG_VERSION == $SRT_BASE ]]; then
+            echo "NOT CHECKING ABI: base version is being built: $SRT_TAG  (not emitting SRT_BASE)"
+            #echo "SRT_BASE=''" >> "$GITHUB_OUTPUT"
+        else
+            echo "WILL CHECK ABI changes $SRT_BASE - $SRT_TAG_VERSION"
+            echo "SRT_BASE=$SRT_BASE" >> "$GITHUB_OUTPUT"
+        fi
+        echo "--- GITHUB_OUTPUT ---"
+        cat $GITHUB_OUTPUT
+        echo "---------------------"
+    - id: upload_pr_dump
+      uses: actions/upload-artifact@v4
+      with:
+        name: abidump_pr
+        path: gitview_pr/_build/libsrt-pr.dump
+
+  build_base:
+    name: Build base version
+    runs-on: ubuntu-latest
+    needs: build_pr
+    if: ${{ needs.build_pr.outputs.base_version != '' }}
+
+    env:
+       SRT_BASE: ${{ needs.build_pr.outputs.base_version }}
+       SRT_TAG_VERSION: ${{ needs.build_pr.outputs.tag_version }}
+    steps:
     - uses: actions/checkout@v3
       with:
-        path: tag
+        path: gitview_base
         ref: ${{ env.SRT_BASE }}
-    - name: configure_tag
+    - id: configure_tag
+      name: Configure (cmake)
       run: |
-        echo $SRT_TAG_VERSION
-        cd tag
+        echo "TAG:$SRT_TAG_VERSION BASE:$SRT_BASE"
+
+        #This is currently a paranoid check - the if should do the job
+        if [[ -z $SRT_BASE ]]; then
+            echo "NO BASE DEFINED. NOT BUILDING"
+            exit 1
+        fi
+        cd gitview_base
         mkdir _build && cd _build
-        cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_UNITTESTS=ON ../
-    - name: build_tag
+        cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_BONDING=1 -DENABLE_PKTINFO=1 -DENABLE_MAXREXMITBW=1 ../
+    - id: build_tag
+      name: Build and dump
+      if: ${{ success() }}
       run: |
-        cd tag      
+        sudo apt install -y abi-dumper
+        sudo apt install -y tcl
+        cd gitview_base      
         cd _build && cmake --build ./
         make install DESTDIR=./installdir
-        abi-dumper libsrt.so -o libsrt-tag.dump -public-headers installdir/usr/local/include/srt/ -lver 1
+        echo "TAGGING BASE BUILD: $SRT_BASE"
+        abi-dumper libsrt.so -o libsrt-base.dump -public-headers installdir/usr/local/include/srt/ -lver $SRT_BASE
+        ls -ld libsrt-base.dump
+        sha256sum libsrt-base.dump
+    - id: upload_base_dump
+      uses: actions/upload-artifact@v4
+      with:
+        name: abidump_base
+        path: gitview_base/_build/libsrt-base.dump
+
+  check_abi:
+    name: Compare ABI
+    runs-on: ubuntu-latest
+    needs: [build_pr, build_base]
+    env:
+       SRT_BASE: ${{ needs.build_pr.outputs.base_version }}
+
+    steps:
+    - name: Download base dump
+      uses: actions/download-artifact@v4
+      with:
+        name: abidump_base
+        path: .
+    - name: Download pr dump
+      uses: actions/download-artifact@v4
+      with:
+        name: abidump_pr
+        path: .
     - name: abi-check
       run: |
-         git clone https://github.com/lvc/abi-compliance-checker.git
-         cd abi-compliance-checker && sudo make install && cd ../
-         abi-compliance-checker -l libsrt -old tag/_build/libsrt-tag.dump -new pull_request/_build/libsrt-pr.dump
-         RES=$?
-         if (( $RES != 0 ))
-          then
-            echo "ABI/API Compatibility check failed with value $?"
-            exit $RES
-          fi
+        sudo apt install -y abi-dumper abi-compliance-checker tcl
+        echo "FILESYSTEM state before running abi-check at $PWD"
+        ls -l
+        sha256sum libsrt-base.dump
+        sha256sum libsrt-pr.dump
+        RES=0
+        abi-compliance-checker -l libsrt -old libsrt-base.dump -new libsrt-pr.dump || RES=$?
+        # Flatten the report for download-preview
+        cd compat_reports
+        REPORT=$(find . -name *.html)
+        cp $REPORT compat_report.html
+        cd ..
+        if (( $RES != 0 )); then
+           echo "ABI/API Compatibility check failed with value $?"
+           echo "RES=$RES" >>$GITHUB_ENV
+           exit 0
+        fi
+    - name: Download report
+      uses: actions/upload-artifact@v7
+      with:
+        name: abi-compliance-report
+        path: compat_reports/compat_report.html
+        archive: false
+    - name: Final result
+      run: |
+        echo "Final result: $RES"
+        exit $RES

.github/workflows/android.yaml

@@ -2,14 +2,14 @@ name: Android
 
 on:
   push:
-    branches: [ master ]
+    branches: [ "master", "dev" ]
   pull_request:
-    branches: [ master ]
+    branches: [ "master", "dev" ]
 
 jobs:
   build:
     name: NDK-R23
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     steps:
     - name: Setup Android NDK R23

.github/workflows/codeql.yml

@@ -2,9 +2,9 @@ name: "CodeQL"
 
 on:
   push:
-    branches: [ "master", "experimental/socket-groups" ]
+    branches: [ "master", "dev" ]
   pull_request:
-    branches: [ "master" ]
+    branches: [ "master", "dev" ]
 
 jobs:
   analyze:

.github/workflows/codespell.yml

@@ -0,0 +1,21 @@
+name: codespell
+
+on: pull_request
+
+jobs:
+  spellcheck:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.10'
+
+      - name: Install dependencies with pip
+        run: pip install --no-warn-script-location --user codespell
+
+      - name: Spellcheck
+        run: codespell --config scripts/codespell/codespell.cfg