Repository navigation
fix: make silent job and peer failures visible and actionable - #9497
Merged
Merged
Conversation
- jobs[N] now matches the [N] shown in the table; jobs["name"] raises on an ambiguous name instead of returning the wrong job - process_approved_jobs reports every approved job it skipped, and skips on (job_name, ds_email) so same-named jobs from other submitters still run - syft_job, syft_rds, syft_enclaves and syft_bg configure their own loggers - "No public encryption bundle" names the cause and remedy per peer state - approve_job checks for the approval file first; JobInfo file listings catch OSError; approve/reject errors name both parties
github-actions
Bot
added
bugfix
pkg:syft-enclave
pkg:syft-bg
pkg:syft-job
pkg:syft-rds
pkg:syft
labels
chore: land syft-pr-review skill update on this branch for testing
chore: land prefetch.sh .claude exclusion on this branch
chore: land naming/duplication standard update on this branch
chore: land naming/duplication corrections on this branch
koenvanderveen
marked this pull request as ready for review
September 2, 2026 15:15
koenvanderveen
requested changes
Sep 2, 2026
…ailures # Conflicts: # packages/syft-enclave/src/syft_enclaves/client.py # packages/syft-enclave/src/syft_enclaves/enclave_job_info.py # packages/syft-job/src/syft_job/job_runner.py # packages/syft-job/tests/test_job_flow.py # packages/syft-rds/src/syft_rds/__init__.py # syft/sync/peers/peer_store.py
rasswanth-s
reviewed
Oct 8, 2026
rasswanth-s
reviewed
Oct 8, 2026
| usually the other party — a data scientist names the data owner, a data | ||
| owner names the submitter — but naming yourself keeps your own. So | ||
| ``jobs["do@x.org"]["analysis"]`` reads as one job, and chaining both — | ||
| ``jobs["do@x.org"]["ds@y.org"]["analysis"]`` — pins the datasite and the |
Collaborator
There was a problem hiding this comment.
This says chaining both emails "pins the datasite and the submitter", but _with_party() matches an email in either role, so the two keys don't fix direction. Repro: a dual-role user has analysis on their own datasite from a peer, and an analysis they submitted to that peer. jobs[me][peer]["analysis"] raises "Multiple jobs are named 'analysis'", and the only chains offered are bare positions. Maybe we can make first email key filter by datasite and the second by submitter ?
rasswanth-s
approved these changes
Oct 8, 2026
rasswanth-s
left a comment
rasswanth-s
left a comment
Collaborator
There was a problem hiding this comment.
Had only minor suggestions, LGTM
koenvanderveen
approved these changes
Oct 9, 2026
pjwerneck
changed the title
pjwerneck
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make silent job and peer failures visible and actionable
Changes
Testing
Asana Task
https://app.asana.com/1/1185126988600652/project/1210542925864934/task/1217980407095929?focus=true