refactor(notification)!: move notification to its own module, notifications

[sthanikan2000]

Summary

Moves notification out of core's root module into its own Go module, github.com/OpenNSW/core/notifications, as was done for storage in #159.

• Why a module: a fix to notification can currently reach a consumer only through a bump of the whole root module. Today that bump also brings workflow's breaking series (refactor(workflow,taskflow)!: rename TaskDone to CompleteStep, TaskType to PluginType, and SubTask* to Step* (1/8) #237, feat(workflow)!: give each TASK node run its own step ID and seq (3/8) #239, feat(workflow)!: make ActivationID the routing key for admin resolution #256).
• Why a new path: a consumer pinned to a root version that still contains notification/ can't add a module at that same path: Go fails with ambiguous import: found package … in multiple modules. Under the new path it can require the module next to its existing root pin.

No behavior changes.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Other (please describe):

Changes Made

• git mv notification notifications. Every file is recorded as a rename, so history follows.
• The package keeps its name, notification. Only the import path changes; code keeps using notification.X. Go allows a package name that differs from its path. The repo's formatter (goimports, run by the pre-commit hook and CI) writes such imports with the name spelled out: notification "github.com/OpenNSW/core/notifications".
• The only code changes are four import lines, in providers/email.go, providers/sms.go and the integration test. Every other Go file is identical to main.
• New notifications/go.mod: go 1.26, requiring remote v0.8.0 and secret v0.2.0, the package's only dependencies. Nothing else in core imports it.
• Root go.mod: after go mod tidy, secret becomes indirect, since only notification used it directly.
• .github/workflows/ci.yml: a Notifications Module job, copied from storage-module. .github/dependabot.yml: "/notifications".
• READMEs: the package README notes the move, and the root table row and architecture diagram use the new name.

Testing

• I have tested this change locally

• I have added tests that prove my fix is effective or that my feature works

• I have tested edge cases

• All existing tests pass

• notifications: go mod tidy, go vet ./..., go test -race ./... pass.

• Root: go mod tidy, go build ./..., go vet ./..., go test ./... pass; the root no longer has notification's two packages.

• No code anywhere references github.com/OpenNSW/core/notification.

• The pre-commit hooks passed, including the go mod tidy check.

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have checked that there are no merge conflicts

Related Issues

Prerequisite for #281.

Screenshots/Demo

N/A

Additional Notes

Breaking: import notification "github.com/OpenNSW/core/notifications" instead of "github.com/OpenNSW/core/notification". The package name and API are unchanged.

Release:

• No tag yet. fix(notifications)!: take each provider's config as a typed struct #281 (stacked on this PR) fixes the notification settings bug. The first tag, notifications/v0.1.0, goes on the result once both merge, so the first published API already includes the fix.
• nsw-srilanka then requires notifications/v0.1.0 next to its current root pin, without bumping the root module, and changes only its 7 import lines.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5fad458c-df1a-4bae-9824-19ff58dc6c4a

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mushrafmim]

LGTM!