Repository navigation
Conversation
Reconstruct translation, scaling and rotation loops from SCES_532.85. Share the two-float point layout and record targeted PAL matches. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds matching C for the PAL routines that translate, scale and rotate arrays of 2D points. All three traverse the array backwards; the rotation routine retains the original order of its two angle-helper calls and floating-point operations.
func_0044B7E0func_0044B820func_0044B860The shared
PalPoint2Dtype contains two floats. The C was reconstructed from the retail executable, without SDK sources, headers, inline assembly or compiler-output patches.Validation:
tools/cc.shpipeline and compared it against the PAL catalogue address and retail bytes: 3 matches, 272 bytes. Translation and scaling match without relocation masking.0x00454158and0x00454140, including object addends.otherrows, preserving every existing map row. Regenerated the progress reports and README; the US report is semantically unchanged.tools/progress.py --checkandtools/progress.py --version pal --checkpass, as doesgit diff --check.This is targeted PAL validation. A full repository rebuild and global relocation audit were not run; no US retail image is available locally. No retail data, disassembly or toolchain files are included.
Based directly on upstream main, independently of #57, #58 and #59. This PR adds three functions to the upstream PAL baseline of 5,138 matched functions / 396,888 bytes; its report therefore records 5,141 / 397,160. Source files do not overlap the currently open PAL contribution PRs.