Repository navigation
Match four PAL scalar smoothing routines - #61
Merged
Merged
Conversation
Reconstruct the target-approach helper and three wrappers from PAL retail code, retaining its return value, comparisons and minimum-step behavior. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds matching C for the PAL scalar target-approach helper and three wrappers. The helper keeps the original snap comparisons, minimum signed step, and returned delta, including returning the unscaled delta when it snaps to the target. The wrappers retain the original integer-to-float conversions and global override behavior.
func_004760C0func_00498038func_0049B418func_0049C260Validation:
tools/cc.shpipeline: 360 bytes match PAL retail at the catalogue addresses. The helper matches with no relocations;fabsfis emitted inline asabs.s.0x004760C0and the HI16/LO16 global reference to0x00221680, including object addends.otherrows, preserving all previous rows. Regenerated the progress reports/README; the US report is semantically unchanged.tools/progress.py --checkandgit diff --checkpass.Full source compilation with
JOBS=8 bash tools/build.shpassed: 5,265 files. A read-only masked-byte check usingtools/match_map.py's compiled-function/retail helpers against every existing PALmatchrow found 6,750 matching places, 0 mismatches and 0 missing source objects. This is not a global relocation audit; the five relocations of this contribution were independently resolved as described above.No US retail image is available locally, so the US-wide match and relocation audits were not run. The new functions were checked directly against PAL retail, with all external references independently verified. No retail data, disassembly, toolchain files or SDK sources are included.
Based directly on upstream main, independently of the earlier open contributions. This PR adds four functions / 360 bytes to the upstream PAL baseline of 5,138 / 396,888; its report records 5,142 / 397,248.