Repository navigation
Conversation
Recover both three-slot scans and the prioritized field/fallback lookup with the original 184-byte record stride and return addresses. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds matching C for three adjacent PAL slot-lookup routines.
func_004A9948scans three slots for the active index (88 bytes);func_004A99A0performs the same scan for a supplied index (64 bytes). Each returns the first empty slot or 3 if none is empty.func_004A99E0returns the address of the first nonzero field at record offsets0x24/0x28, falling back to the three-slot array (80 bytes). Its partial record type preserves the0xB8stride.Validation:
tools/cc.sh: 232 bytes match PAL retail at their catalogue addresses.0x00506BB8and all four HI16/LO16 reference pairs againstD_0020C710andD_00308208, including object addends.otherrows, retaining every prior row. Regenerated reports/README; the US report is semantically unchanged.tools/progress.py --checkandgit diff --checkpass.The existing repository sources were compiled in the preceding contribution's full compilation run; these three final sources were compiled and verified separately. No US retail image is available locally, so global US match/relocation audits were not run. No retail data, disassembly or toolchain files are included.
Based directly on upstream main, independently of the other open contributions. This PR adds three functions / 232 bytes to the PAL baseline of 5,138 / 396,888; its report records 5,141 / 397,120.