Repository navigation
Conversation
Reconstruct the four-entry nonzero type scan and linked-object type test with the original null checks, offsets and unsigned range comparison. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds matching C for two PAL type predicates.
func_00528538tests whether a nonzero type occurs in the four bytes beginning atD_00171BC0 + 0x29(64 bytes), retaining its unused first argument.func_00540958follows the original object links at offsets0x2EF4and0x2B0, then checks whether the byte at0x67is 7, 8 or 10 (64 bytes). Its only null check is the original outer-link check.Validation:
tools/cc.sh: 128 bytes match PAL retail at their catalogue addresses.0x00171BC0, including the object addend.otherrows, preserving every previous row. Regenerated reports/README; the US report is semantically unchanged.tools/progress.py --check, both versions oftools/match_map.py --check, andgit diff --checkpass.The existing repository sources were compiled in an earlier contribution's full compilation run; these two final sources were compiled and verified separately. No US retail image is available locally, so global US match/relocation audits were not run. No retail data, disassembly or toolchain files are included.
Based directly on upstream main, independently of the other open contributions. This PR adds two functions / 128 bytes to the PAL baseline of 5,138 / 396,888; its report records 5,140 / 397,016.