Repository navigation
Conversation
Reconstruct the flag-gated setter and getter, including the original duration reset, default value and dirty-flag behavior. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds matching C for the PAL object-parameter setter
func_00489498(120 bytes) and getterfunc_00489510(64 bytes), sharing a partial state layout. The setter uses the supplied value/duration and sets the dirty flag only when flag0x20is enabled and the duration is positive; otherwise it resets the value to 1.0 and the duration to zero. The getter returns 1.0 when the state is absent or the flag is disabled. Both retain the original null-state behavior.Validation:
tools/cc.sh: 184 bytes match PAL retail at their catalogue addresses.0x00476ED0, including object addends. The partial structure retains offsets0x00,0x0C,0x104and0x108.otherrows, preserving every previous row. Regenerated reports/README; the US report is semantically unchanged.tools/progress.py --check, both versions oftools/match_map.py --check, andgit diff --checkpass.The existing repository sources were compiled in an earlier contribution's full compilation run; these two final sources were compiled and verified separately. No US retail image is available locally, so global US match/relocation audits were not run. No retail data, disassembly, toolchain files or SDK sources are included.
Based directly on upstream main, independently of the other open contributions. This PR adds two functions / 184 bytes to the PAL baseline of 5,138 / 396,888; its report records 5,140 / 397,072.