Repository navigation
Conversation
Preserve the signed callback argument conversion, distinct event stores, state transitions and conditional notification writes. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds matching C for the adjacent PAL event-state callbacks
func_0048A7E8(76 bytes) andfunc_0048A838(84 bytes), with a shared partial structure. Both reset state on a zero event and transition to state 4 from their respective states 1 and 9, conditionally setting the notification at0x002069FC. The second callback preserves its negative-events-only store, and both retain the original signed 32-bit pointer conversion from the 64-bit callback argument.Validation: compiled both final sources through the repository's SN compiler and
tools/cc.sh; 160 bytes match PAL retail at their catalogue addresses. Independently resolved both HI16/LO16 relocation pairs to0x002069FC, including object addends. Both versions oftools/progress.py --checkandtools/match_map.py --check, plusgit diff --check, pass.Only the two verified PAL map rows and corresponding US
otherrows were added; all previous rows were preserved. Reports/README were regenerated; the US report is semantically unchanged. Based directly on upstream main independently of other open contributions; PAL changes from 5,138 / 396,888 to 5,140 matched functions / 397,048 bytes.The baseline sources passed a full compilation in preceding work; these final new sources were compiled and byte-checked separately. No US image is available locally, so global US match/relocation audits were not run. No retail data, disassembly, SDK sources or toolchain files are included.