Repository navigation
Conversation
Preserve the flag-first check and conditional global/mode fallback in func_0049B118, with the original object-link and state offsets. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds matching C for PAL
func_0049B118(88 bytes). It obtains the indexed object throughfunc_00511CC0, follows its state pointer at0x2F00, and returns true when state flag0x800is set, or whenD_0021EE54 != 1and the mode byte at0x551is 1. It preserves the original short-circuit order and null-pointer assumptions.Validation: the final source compiles through the repository's SN compiler and
tools/cc.shto a PAL retail match at catalogue address0x0049B118. Independently resolved the call target0x00511CC0and HI16/LO16 global reference0x0021EE54, including object addends. Both versions oftools/progress.py --checkandtools/match_map.py --check, plusgit diff --check, pass.Only the verified new PAL map row and US
otherrow were added; all existing rows were retained. Reports/README were regenerated; the US report is semantically unchanged. Based directly on upstream main independently of the other open PRs; PAL changes from 5,138 / 396,888 to 5,139 matched functions / 396,976 bytes.The baseline sources passed a full compilation in preceding work; this final new source was compiled and byte-checked separately. No US image is available locally, so global US match/relocation audits were not run. No retail data, disassembly, SDK sources or toolchain files are included.