Repository navigation
Conversation
Preserve the object lookup, wrapped angle increment and three subsequent calls of func_0054E910 in their original order. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds matching C for PAL
func_0054E910(88 bytes). It obtains object index 0, updates the angle at0xF8throughfunc_00454328with the original float constant0x3CC90FDB, then makes the original three subsequent calls in order.Validation: compiled the final source through the repository's SN compiler and
tools/cc.sh; all 88 bytes match PAL retail at catalogue address0x0054E910, with only call fields masked. Independently resolved all five calls, including object addends, to0x0046E100,0x00454328,0x0046F008,0x0046F6B8and0x00470FD0. Both versions oftools/progress.py --checkandtools/match_map.py --check, plusgit diff --check, pass.Only the new verified PAL map row and US
otherrow were added; all previous rows were retained. Reports/README were regenerated; the US report is semantically unchanged. Based directly on upstream main independently of the other open PRs; PAL changes from 5,138 / 396,888 to 5,139 matched functions / 396,976 bytes.The baseline sources passed a full compilation in preceding work; this final new source was compiled and byte-checked separately. No US image is available locally, so global US match/relocation audits were not run. No retail data, disassembly, SDK sources or toolchain files are included.