Repository navigation
Match 45 NTSC-U helpers with pinned compiler profiles - #71
Draft
Joebannerlord wants to merge 1 commit into
Draft
Joebannerlord wants to merge 1 commit into
Joebannerlord wants to merge 1 commit into
Conversation
Add 45 independently verified functions totaling 1,936 retail bytes and the pinned compiler routes needed to reproduce them. Preserve whole-file flags, upstream SN float handling and the original reconstructed sources. Correct the proven US inventory split at 01EC3498 without unrelated churn. Full compilation passes for 5,306 source files; 26 route/profile tests pass. Fresh objects match retail after standard relocation resolution in memory, with 28 actual call/address target groups verified and no object patches. US coverage/progress passes at 4,520 functions / 352,712 bytes. The like-for-like audit gains 45 exact functions with no new discrepancies. Retain three existing non-exact and 827 unlisted functions, 80 relocation mismatches and three unresolved targets. PAL inputs are unavailable; its coverage guard lacks 45 new US rows and must be completed before merge. No PAL result, game behavior or whole-tree clean audit is claimed. Retail inputs, binaries, generated assembly and scratch evidence stay local. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 45 independently verified NTSC-U functions / 1,936 retail bytes, together with the pinned compiler profiles needed to reproduce them. The collection covers five core routines and forty network getters, initializers, predicates and callback/copy/zeroing wrappers. The branch contains one commit based on current upstream main.
Draft: PAL mapping is still needed before merge. PAL retail inputs are unavailable locally. The 45 new US sources have no verified PAL map rows, so
tools/progress.py --version pal --checkfails its coverage guard. PAL source, map and report are unchanged; no untested PAL match or mismatch status has been fabricated. A maintainer with PAL inputs can pull this branch and regenerate/review the PAL map.Changes
EXACTresults.@lit4, and do not patch compiler output or objects. Compiler binaries/private runtimes are not included.01EC3498using the official inventory generator: 32 matched bytes plus the separate, unmatched 12-byte01EC34B8. This removes the earlier twelve-byte progress overcredit.Validation
git diff --checkpasses.All 17 currently open PR patches were checked; no direct overlap with these functions was found. The deferred
func_01EEEDA0near miss is excluded. No retail programs, disc data, generated assembly, build output, proprietary toolchains, SDK source/headers/samples, or local scratch files are included. Matching is paused while this collection is staged for review.45 verified functions
func_001221D8func_0014ADD8func_0014C368func_0014D010func_0014DE80func_01E9B268func_01EA0610func_01EA47E8func_01EA4EE8func_01EA71C8func_01EA88A0func_01EA9800func_01EA9D98func_01EA9FE8func_01EAA020func_01EAA060func_01EAA0D0func_01EB0D78func_01EB4DB0func_01EB4DE8func_01EB4E40func_01EB4FF0func_01EB7288func_01EB72B0func_01EB72D8func_01EB84B8func_01EBDED0func_01EBDEF0func_01EC2840func_01EC3498func_01EC52B8func_01EC9B08func_01ED5548func_01ED5570func_01ED5638func_01ED8500func_01ED9BE8func_01EDA098func_01EDB030func_01EDB388func_01EED4D8func_01EEE000func_01EF21FCfunc_01EFA2A4func_01F07154