Repository navigation
feat(toolcall-schema-fuzz): move toolcall_schema_fuzz benchmark into the harness - #143
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
Original prompt from Abhinav
|
There was a problem hiding this comment.
Note
Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Moves the benchmark (cases, grid/arbs, realistic dataset, regressions, sentinel, solver, scorer, discovery/reword/report CLIs) from openrouter-web internal-benchmarks into the harness and registers it as a Kepler benchmark.
TL;DR
Moves the whole
toolcall_schema_fuzzbenchmark (dataset, cases, solver, scorer, generators, CLIs) from openrouter-webinternal-benchmarksinto the harness and registers it as a catalog benchmark.What changed?
src/benchmarks/toolcall-schema-fuzz/: grid + fast-check arbs (grid.ts,arb/*,shape.ts,constructs.ts),cases.ts/sentinel.ts/regressions.ts(+regressions.json), realistic rewording (realistic/*,realistic/wordings.json),json-schema.tsvalidator,solver.ts,scorer.ts,dataset.ts,benchmark.ts, and thecli/discover.ts/cli/reword.ts/cli/report.tstools, with colocated tests.benchmark-config.ts(ToolCallSchemaFuzzBenchmarkConfigSchema,generator: realistic | sentinel | regressions, defaultrealistic),benchmark-meta.ts(temperature 0, 1 epoch),registry.ts, and the CLI.internal/guards,internal/zod,internal/either, provider/retry helpers);fast-checkadded as a dependency.src/datasets/toolcall-schema-fuzzexport is dropped; the JSON now lives with the benchmark.Why?
The benchmark only ran from the private monorepo. Moving it public lets Kepler run it like every other harness benchmark; openrouter-web will pick it up via
scripts/subtree-pull-bench-harness.shand delete its internal copy.How to test
bun run bench --benchmark toolcall_schema_fuzz --model google/gemini-2.5-flash --limit 20 --concurrency 4 bun src/benchmarks/toolcall-schema-fuzz/cli/report.ts bench-results/toolcall_schema_fuzz-*.parquetLocal smoke: 18/20 passing on
google/gemini-2.5-flash(first 20 realistic samples,singlescenario).Benchmark impact
New benchmark id in the public catalog. Sample ids and generator contents match the internal version; scoring classes are unchanged.
Reviewer focus
solver.ts: talks to/chat/completionsdirectly (tool history replay,parallel_tool_calls, endpoint/provider routing) rather than throughModelService.openrouter(no-comments); context moved toREADME.md.Checklist
Link to Devin session: https://openrouter.devinenterprise.com/sessions/72a3f13c847645c5b06306d88cec089d
Open in Devin Desktop: https://openrouter.devinenterprise.com/desktop/session/72a3f13c847645c5b06306d88cec089d?variant=devin
Requested by: @abhinav-pola