feat: emit DeviceUpdateType.Paired when a device consumes a pair code#331
Merged
LucHeart merged 3 commits intoJul 3, 2026
Merged
Conversation
Add a Paired value to DeviceUpdateType and emit it to the device owner after a pair code is consumed, so clients are notified when a device pairs.
|
Ready to review this PR? Stage has broken it down into 3 individual chapters for you:
Chapters generated by Stage for commit b221847 on Jul 3, 2026 10:13am UTC. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new device update event (DeviceUpdateType.Paired) and emits it when a device consumes a pair code, enabling clients to react to device pairing via the existing device-update delivery mechanisms (SignalR + Redis pub/sub).
Changes:
- Add
DeviceUpdateType.Pairedto the shared update-type enum. - Inject
IDeviceUpdateServiceintoDeviceControllerand emit aPaireddevice update after pair-code consumption.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Common/Models/DeviceUpdateType.cs | Adds the new Paired update type for pairing notifications. |
| API/Controller/Device/_ApiController.cs | Injects IDeviceUpdateService into DeviceController for emitting updates. |
| API/Controller/Device/Pair.cs | Emits DeviceUpdateType.Paired after consuming a pair code (targeting the device owner). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
LucHeart
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Pairedvalue to theDeviceUpdateTypeenum and emits it when a device consumes a pair code, so clients are notified when a device pairs.This is useful for closing the pairing dialog automatically after device has paired