Translate remaining functions from winasm.asm - #111
Merged
ZivDero merged 14 commits intoSep 3, 2026
Conversation
|
Development builds of 63f778a: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
tinix0
force-pushed
the
translate-voxel-drawing-colour
branch
2 times, most recently
from
September 2, 2026 17:19
499a2a2 to
32b9a53
Compare
ZivDero
requested changes
Sep 3, 2026
ZivDero
left a comment
ZivDero
left a comment
Member
There was a problem hiding this comment.
A few notes.
- There is some confusion going on here with MMX/non-MMX. Probably just better to drop any MMX references.
- The test is wrong because
VoxelNormalTranslateTableis not initialized in it. - colorgolden.h still carries 32 non-MMX brighten cases that coloropstest.cpp skips with if (test.Mmx == 0) continue; drop them from the generator now that the path is gone. The two separate if (format.Mask == ALTERNATE_MARKER) blocks in Brighten_Color want to be one if/else. And UseMMX/UseCMOV in getcpu.cpp become dead once winasm.asm goes (unvq_asm.asm doesn't reference them).
No documentation update: tests/colorops and tests/voxeldraw check the C++ port against golden vectors recorded from the original assembly, so documented behavior is unchanged.
tinix0
force-pushed
the
translate-voxel-drawing-colour
branch
from
September 3, 2026 19:07
32b9a53 to
63f778a
Compare
ZivDero
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translates Adjust_Color and Brighten_Color from ASM to C++. Only MMX variant is kept since we target SSE2. Drops ASM functions from VoxelDrawFunctions and fixes up the C++ implementation to match ASM. Validated with generated tests that compare C++ outputs against original assembly outputs.