Make the VQA seek command's origin explicit - #114
Open
mischa85 wants to merge 3 commits into
Open
Conversation
mischa85
added a commit
to mischa85/OpenTS
that referenced
this pull request
Sep 3, 2026
Krisztiaan
suggested changes
Sep 5, 2026
Krisztiaan
left a comment
Krisztiaan
left a comment
Contributor
There was a problem hiding this comment.
Nice, just an extra step suggested
| */ | ||
| case VQACMD_SEEK: | ||
| error = (lseek(fh, nbytes, (long)buffer) == -1); | ||
| error = (lseek(fh, nbytes, (int)(intptr_t)buffer) == -1); |
Contributor
There was a problem hiding this comment.
Apply the same pointer-width decode and named origins to VQACCFileHandler, VQAMixFileHandler in vqa.cpp too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VQACMD_SEEKcarries lseek's origin in its buffer argument, but the comment in both stream handlers said "Buffer has no meaning here", and the origin was spelled five ways across 15 call sites:SEEK_CUR,SEEK_SET,NULL,0and(void *)1. All of them now name the constant. The origin is also taken back throughintptr_trather thanint, which truncated on a 64-bit target.Behaviour preserved:
SEEK_SETis0andSEEK_CURis1, so every rename keeps the value it had.