-
Notifications
You must be signed in to change notification settings - Fork 49
Separate video presentation from Win32 window details #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ZivDero
merged 5 commits into
OpenTS-Developers:main
from
Krisztiaan:refactor/platform-window-boundary
Sep 3, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a1adf4e
Extract native window boundary
Krisztiaan 3b83d12
Use explicit native window construction
Krisztiaan 9571bef
Separate display timing and identify native windows
Krisztiaan cf0eeb0
Document the native window boundary
Krisztiaan f600e60
Apply suggestion from @ZivDero
ZivDero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /******************************************************************************* | ||
| * O P E N T S | ||
| ******************************************************************************* | ||
| * SPDX-License-Identifier: GPL-3.0-or-later | ||
| * Copyright 2026 OpenTS contributors | ||
| * | ||
| * See LICENSE.md for applicable additional terms and warranty disclaimers. | ||
| ******************************************************************************/ | ||
|
|
||
| #pragma once | ||
|
|
||
|
|
||
| enum NativeWindowType | ||
| { | ||
| NATIVE_WINDOW_DEFAULT, | ||
| NATIVE_WINDOW_WAYLAND, | ||
| }; | ||
|
|
||
|
|
||
| // The native handles bgfx needs to present into a window supplied by the application shell. | ||
| // Display is unused on platforms where the window identifies its display by itself. | ||
| struct NativeWindow | ||
| { | ||
| NativeWindowType Type; | ||
| void * Display; | ||
| void * Handle; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maaaaybe this makes sense now